Talk:Xin Zhao/@comment-26278874-20200106212722/@comment-30237825-20200106233831

Yup. On-hit effects and On-attack effects are different, though it's more recognisable on ranged champions on-attack effects will always happen when an attack is declared, but on-hit effects only if they connect, as there is effects that prevent that